-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SnowflakeOperator and UcToSnowflakeOperator to accept sql_file and custom dbx sql #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckonuganti
reviewed
May 15, 2024
ckonuganti
reviewed
May 15, 2024
ckonuganti
reviewed
May 15, 2024
ckonuganti
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes related to the new feature of running sql files instead of building or passing queries looks good to me .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Snowflake and UctoSnowflakeOperator Operators to accept sql file and custom db_sql queries as inputs
Description
It is an enhancement to pass sql_file to Snowflake Operator and custom sql to extract data from Unity catalog.
Below are the changes implemented as part of this PR
Related Issue
#115
Motivation and Context
This is an enhancement to account for below use cases
How Has This Been Tested?
Tested the updated operators for multiple scenarios
Tested the UcToSnowflakeOperator for below scenarios
Screenshots (if appropriate):
Make check result
![Screenshot 2024-05-15 at 11 51 33 AM](https://private-user-images.githubusercontent.com/43893120/330925877-b1c3e3d2-ac4e-49ca-8078-abff3747d861.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTQ5MDIsIm5iZiI6MTcxODg1NDYwMiwicGF0aCI6Ii80Mzg5MzEyMC8zMzA5MjU4NzctYjFjM2UzZDItYWM0ZS00OWNhLTgwNzgtYWJmZjM3NDdkODYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMzY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ2YTZjYTRjZWQ3YTJkZGFlZGFiODY0Njc1ZTgyOTA1OGU0NDYzNWZjNWI4MDBlNzE1NWZjMDUxZjY2NmVjZDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eWtQ1kmwPaF-HEgKGs9tQpXAS9LwswhHtUdb7mQQj7Y)
![image](https://private-user-images.githubusercontent.com/43893120/330929596-694b6dac-0c1a-4cb7-9314-12a917c0cc58.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTQ5MDIsIm5iZiI6MTcxODg1NDYwMiwicGF0aCI6Ii80Mzg5MzEyMC8zMzA5Mjk1OTYtNjk0YjZkYWMtMGMxYS00Y2I3LTkzMTQtMTJhOTE3YzBjYzU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMzY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzN2ZlZTdjZWQxMDEyN2Y5NjA3NGFjMzhmMTk4MDBhYzdiZWI1MjFmY2Q5MjU0Njg3ZmY2YmM3ZmJmZjE1YjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.muyYtPQwRBqBOguSh6qwUPf15luMUfSP57CFN9MhB7c)
![image](https://private-user-images.githubusercontent.com/43893120/330929685-ba59a680-4f83-4ecc-b099-1b294baf68f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTQ5MDIsIm5iZiI6MTcxODg1NDYwMiwicGF0aCI6Ii80Mzg5MzEyMC8zMzA5Mjk2ODUtYmE1OWE2ODAtNGY4My00ZWNjLWIwOTktMWIyOTRiYWY2OGY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMzY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0OTFjMmMyMzRhOWVjMTQzZjg3MmY0YWYyNTcxNDM2Y2U2ZjRjOWJkZjIzZTQ2N2M4YjE2NWNjOTY2M2FmYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rD1OWsVp16FjVdTpK_235ITxNcVW0v60j5qV4ScOkfU)
![image](https://private-user-images.githubusercontent.com/43893120/330929781-0ee35b6b-2b2f-4137-8745-0a471f1c43ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTQ5MDIsIm5iZiI6MTcxODg1NDYwMiwicGF0aCI6Ii80Mzg5MzEyMC8zMzA5Mjk3ODEtMGVlMzViNmItMmIyZi00MTM3LTg3NDUtMGE0NzFmMWM0M2FkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMzY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4MGUzMDgyYTcxNDQ0ZmRkZDQ3MGYwYTg2YzA3OWFiZjBiNjU2MDc4MTNhMjliMzFkMDNmNjk5OWUwYTYxZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D-SPCDXwTZYTMg9URHYhVOo-_1FUy25w_Bh8VvkCsic)
![image](https://private-user-images.githubusercontent.com/43893120/330929963-8916cef3-92d7-4fbe-9259-705d7a3e988a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTQ5MDIsIm5iZiI6MTcxODg1NDYwMiwicGF0aCI6Ii80Mzg5MzEyMC8zMzA5Mjk5NjMtODkxNmNlZjMtOTJkNy00ZmJlLTkyNTktNzA1ZDdhM2U5ODhhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMzY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThmZWU3MTViMzBjNjMxNGRlZTYzNTc3M2ZiZDE3Yjk5MjgxMDdhMjAzOGMxOWZhNjk5MDU3NmZiZGYyZWM1NDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.w8VtGKR7Qoh_eYmj8IA8yE2jGLzy63oZcFeYWny0YAw)
Updated brickflow operators workflow
Types of changes
Checklist: