Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

chore/update dashboard dependencies #247

Merged
merged 9 commits into from
Mar 2, 2020

Conversation

thismax
Copy link
Contributor

@thismax thismax commented Feb 26, 2020

  • update cerberus-dashboard module to use react-scripts
  • remove non-idiomatic/unsupported @connect and @redux-form decorators
  • update gradle wrapper
  • relocated files
  • updated project formatting

Copy link
Contributor

@fieldju fieldju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thismax I didn't read every single file but the approach you outlined in the PR description of moving to the CRA scripts and updating the things it doesn't support (decorators) and applying a formatter sounds pretty solid.

@fieldju
Copy link
Contributor

fieldju commented Feb 28, 2020

The build is failing @mayitbeegh because there are some new CVE's that need to be addressed.
That is unrelated to this PR, and is also causing @rdong333's PR build to fail

"production": [
">0.2%",
"not dead",
"not op_mini all"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with opera mini?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default browser list for react-scripts: https://create-react-app.dev/docs/supported-browsers-features/

@thismax thismax merged commit 12b5cc9 into master Mar 2, 2020
@thismax thismax deleted the chore/update-dashboard-dependencies branch March 2, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants