Fix diff roi #267
Closed
Fix diff roi #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom correlation.py
This function will provide the indices, number of pixels and
pixel indices when a circular roi is divided into pies
|
@tacaswell I think I have to close the PR #248 Divide the circle : find the indices, number of pixels, pixel indices. I fixed this new PR, I fixed all the functions in this , the test are passing but there is a problem with the coverage,(missed 7 lines) |
|
Suggested name changes:
|
|
Scikit-image has fast functions based on published CS literature for drawing rings: http://scikit-image.org/docs/dev/api/skimage.draw.html#skimage.draw.circle |
|
|
||
| return mesh.reshape(detector_size), roi_inds, num_pixels, pixel_list | ||
| return mesh.reshape(detector_size), roi_labels, indices |
There was a problem hiding this comment.
Only return the first bit, not the second two.
Merged
|
What is this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the functions in the diff_roi_choice.py after changes in the correlation.py