Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gendered Language: Feature or Bug in Software Documentation? #273

Merged
merged 3 commits into from
Apr 28, 2015
Merged

Gendered Language: Feature or Bug in Software Documentation? #273

merged 3 commits into from
Apr 28, 2015

Conversation

ericdill
Copy link
Member

I was inspired by https://modelviewculture.com/pieces/gendered-language-feature-or-bug-in-software-documentation.

This PR adds tests to all docstrings in our library to prevent gendered language from leaking in

@ericdill
Copy link
Member Author

@danielballan
Copy link
Member

For a practical review of ways to avoid gendered assumptions without resorting to contorted English, see Brian Garder, author of "Modern American Usage" in a series of three short posts. The most relevant is this one. @ericdill maybe add a link to this PR?

@danielballan
Copy link
Member

Is full-on blacklisting the male pronoun is the right way to ensure openness in the library? Sometimes we might want to refer to the work of a specific researcher who has a gender. Maybe a warning would be better than a test failure.

@tacaswell
Copy link
Member

👍 on this.

I am inclined to say we deal with the case where we must use a pronoun to refer to a researcher in a docstring at a when it comes up. I suspect that if we have enough text in the docstring that using a pronoun is required there is too much text and it should move off to the rst documents anyway.

@danielballan
Copy link
Member

It looks like there is some accidentally-committed code in here.

@ericdill
Copy link
Member Author

It is not accidentally committed. This new test actually imports every module and apparently some of our relative imports were incorrect

@ericdill
Copy link
Member Author

@danielballan Added a link to the writing guidelines. Thanks for that

@ericdill
Copy link
Member Author

Also, this should really make use of regex, but I suck at it

tacaswell added a commit that referenced this pull request Apr 28, 2015
@tacaswell tacaswell merged commit bc00195 into scikit-beam:master Apr 28, 2015
@ericdill ericdill deleted the down-with-the-meritocracy branch September 18, 2015 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants