Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a shuffle button to shorts pages #243

Merged
merged 28 commits into from
Nov 30, 2023
Merged

Added a shuffle button to shorts pages #243

merged 28 commits into from
Nov 30, 2023

Conversation

NikkelM
Copy link
Owner

@NikkelM NikkelM commented Nov 26, 2023

Closes #51

@NikkelM NikkelM self-assigned this Nov 26, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7039178296

  • 49 of 61 (80.33%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 93.799%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils.js 15 17 88.24%
src/shuffleVideo.js 32 42 76.19%
Files with Coverage Reduction New Missed Lines %
src/shuffleVideo.js 3 92.55%
Totals Coverage Status
Change from base Build 6991268767: -0.8%
Covered Lines: 1316
Relevant Lines: 1403
💛 - Coveralls

@NikkelM
Distinguish between large button and small button when changing text
b3aac50
@NikkelM
Distinguish between small and large button, pass active button reference
1663f5a
@NikkelM
Added animations, state handling to small shuffle button
d42772f
@NikkelM
Updated Readme
1372d1b
@NikkelM
Removed unneeded span
a6adcec
@NikkelM
Removed log statement
30af91c
@NikkelM
Updated changelog
6906414
@NikkelM
Correctly update small button style for text
9cc5cc3
@NikkelM
Updated hints, readme
1a40313
@NikkelM
Updated package description
bc08ba1
@NikkelM
Fixed big button text
3b155de
@NikkelM
Better error display, formatting
45c3c7e
@NikkelM
Switched variable meaning, better tooltip for small button
488a665
@NikkelM
Fixed small button text switching after shuffle had finished, and int…
4f5a45c 
…erval checking too long
@NikkelM
Use new getPageTypeFromURL method
555fdb0
@NikkelM
Moved comment
c8de455
@NikkelM
Updated changelog
da6fbb9
@NikkelM
Renamed function
d2d7d97
@NikkelM
Fixed rename
23fd71a
@NikkelM
Pause playing short after shuffle
1fa1bc8
@NikkelM
Switched if branches
79a23b0
@NikkelM
Added small delay before error alerting, moved up text element defini…
80dad7a 
…tion
@NikkelM
Removed null assignments
62a8544
@NikkelM
Refactored adding button to page
4b16bb5
@NikkelM NikkelM merged commit eebdeba into main Nov 30, 2023
2 checks passed
@NikkelM NikkelM deleted the shuffle-button-shorts-page branch November 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NikkelM NikkelM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI][Button] Add shuffle button to "shorts" video pages
2 participants
@NikkelM @coveralls