Skip to content

Commit

Permalink
Merge pull request #90 from kaydensigh/relative_path
Browse files Browse the repository at this point in the history
Add Trunk.toml and make urls relative.
  • Loading branch information
NiklasEi authored Dec 30, 2023
2 parents 505aff3 + 27a2e06 commit d50ecba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ on:

# ToDo: adapt names
env:
# heads-up: this value is used as a pattern in an sed command as a workaround for a trunk issue
# if you use special characters, take a look at the 'Make paths relative' step in the 'build-web' job
# This variable is used to name release output files.
GAME_EXECUTABLE_NAME: bevy_game
GAME_OSX_APP_NAME: BevyGame

Expand Down Expand Up @@ -196,12 +195,6 @@ jobs:
uses: NiklasEi/wasm-opt-action@v2
with:
file: dist/*.wasm
# Trunk cannot import assets from relative paths (see e.g. https://github.com/thedodd/trunk/issues/395)
# On sites like itch.io, we don't know on which base path the game gets served, so we need to rewrite all links to be relative
- name: Make paths relative
run: |
sed -i 's/\/index/.\/index/g' dist/index.html
sed -i 's/\/${{ env.GAME_EXECUTABLE_NAME }}/.\/${{ env.GAME_EXECUTABLE_NAME }}/g' dist/index.html
- name: Zip release
uses: vimtor/action-zip@v1.1
with:
Expand Down
5 changes: 5 additions & 0 deletions Trunk.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[build]
public_url = "./"

[serve]
port = 8080

0 comments on commit d50ecba

Please sign in to comment.