Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a new event if the user closes the prompt #454

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yoann-chambrun
Copy link

Description

Send a new event if the user close the biometrics modal.
A new event has been added, just a minor version is needed for me.

How did you test your changes?

Copy link
Owner

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Please check out the comment for the version.

Maybe a minor release is fine, too. This just adds a new error that needs to be handled.

@yoann-chambrun If you didn't now: You can just push changes to your branch and the PR will update. No need to create a new PR.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-fingerprint-aio",
"version": "5.0.1",
"version": "5.1.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "5.1.0",
"version": "5.0.1",

Please don't change versions in PRs. It's part of the release process.

.vscode/settings.json Show resolved Hide resolved
Copy link
Owner

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for next minor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants