-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep unminified JS files in builds #165
Conversation
@NikolayRys I'm not sure why tests fail 馃 Is it something CI specific? I didn't notice that locally, will take a closer look then. |
Hi, thank you for the pull request, we need it for 3.0. I'm a bit busy right now, but I'll review this one and other PRs next week. |
@vitkarpov, awesome job, thank you!
|
@NikolayRys done 馃憣 |
@NikolayRys I reviewed this PR one again and noticed a thing I'm not sure about and one thing that probably needs to be fixed:
|
Nah, I see the difference now: window.addEventListener('load', () => {
likely.initiate();
}); Everything's fine then. |
Oh, it's a very good point about css. I think, we need to be consistent now and have likely.min.css minified as well, could you please add it too? Also, please remove the 3.0.0 bump, we are not there yet to finalize the release, and there will be several more changes to it, here's the list: #163 |
Yes, will do within this PR.
Gotcha, do we need to add built files to the repo then? Anyway, it shouldn't hurt anybody. |
@NikolayRys Done 馃帀 |
Thanks for the good work, this was a useful change. About the builds, we were keeping them always in this project in the repo, it's just for consistency and for the case if somebody wants the edge version :) |
Fixes #149
This is a breaking change! (for
3.x
release)馃憜 that's how build folder looks like after running
npm run-script build
. What's beenlikely
before turns intolikely.min
now andlikely
file is unminified instead.How does it work
Minification feature is built-in and runs under
-p
flag. There are 2 configs now: base is what we already have andwebpack.config.min.js
inherits the base one. The min config has "min-postfixed keys" in entries to get[name].min.js
files.npm run-script build
runs Webpack twice: one without-p
mode with the base config and another in production mode (that's where minifications come) with the min config (to get proper file names).