Maintenance #1
Closed
Maintenance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handles M115 GEOMETRY capability report * No need to use a separate format string... * Origin has no effect on machine height... * ♻️ virtual: refactor area report Now depends on a single config setting `m115ReportArea`. If true, the virtual printer will generate an area report from the current printer profile and include it in the M115 reponse. Ships as false by default. --------- Co-authored-by: Gina Häußge <gina@octoprint.org>
It was not storing its current value properly, thanks to an incomplete refactoring ages ago during which etag and lastmodified types were joined into httpheader. Closes #4806
It was completely non deterministic due to no info about last print and upload date having been collected in the backend. This is fixed now, making storing by last upload date, last print etc also apply to folders. The corresponding data has also been made available in the frontend. Closes #4800
`None` values were converted to an empty string by sv, leading to comparison issues with (correct) integers. Using the default order value for sv fixes that. Closes #4818
Also improve error messaging in that regard (and fix some typo issues in an existing FAQ URL). Closes #4819
* improve pause gcode * linting * comment and improve description * typo
Thanks for the (unintentional) heads-up, @cp2004
…o anything due to the startswith check. (#4794)
Co-authored-by: Gina Häußge <gina@octoprint.org>
* log extruder and file position on pause * satisfy linter * move values into event, include also cancel action * please the linter * updated event documentation * ♻️ Remove data redundancy We really don't want to include origin and filename in the event again when all we actually want is the fileposition. --------- Co-authored-by: Gina Häußge <gina@octoprint.org>
Needs to take the current base url and possible path prefixes into account. Closes #4829
* provide variables from multiple plugins * 🎨 Fix linter issues --------- Co-authored-by: Gina Häußge <gina@octoprint.org> Closes #4756
We need to reset emptyLayers (and should - for the sake of consistency - also reset percentageByLayer) after running an analysis because otherwise old values will stay in there until page reload, causing layers to not render that actually are not empty but were in any previously loaded model.
Get rid of outdated vendored imp.py. Also fixes editable plugin installs under current tooling.
Should make unit tests happy again.
3.12 seems to be significantly faster than 3.7, let's utilize that!
They are causing issues with third party plugins, and the proper roles and labels should provider the same and hopefully even better functionality. Update of #4928, see also LazeMSS/OctoPrint-UICustomizer#315
Will contain the base version (so 1.11.0 in case of 1.11.0.dev, 1.11.0rc* etc)
Should reduce the annoyance of the reload overlay caused by settings updates in the background.
We so far only ever set it on server connect, which would cause a reload overlay to trigger on every reconnect if the settings had been changed in any way since the initial connect. This should prevent this in most cases.
Ensure reauthentication won't be requested for users that are authenticated through remote user headers on the incoming requests. Also refactored login mechanism handling a bit. Closes #4966
Empty filters would filter everything, that was certainly not intended. Closes #4967
It required checking the warnings and funding calls even if they weren't present. This is now checked first. Closes #4969
Should reduce the annoyance of the reload overlay caused by settings updates in the background. It should also help with the reload prompts sometimes observed during reauthentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
new feature, or maintenance if it's a bug fix or improvement of
existing functionality for the current stable version (no PRs
against master or anything else please)
(no PRs from your version of master, maintenance or devel please),
e.g. dev/my_new_feature or fix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less source files, not the .css files (those are generated with
lessc)
have added unit tests
nothing broke
What does this PR do and why is it necessary?
How was it tested? How can it be tested by the reviewer?
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes