Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles need to render as UTF-8 strings #69

Closed
Rocamoya opened this issue Apr 7, 2013 · 4 comments
Closed

Subtitles need to render as UTF-8 strings #69

Rocamoya opened this issue Apr 7, 2013 · 4 comments
Milestone

Comments

@Rocamoya
Copy link

Rocamoya commented Apr 7, 2013

Im found the problem with some subtitles.
When the Movie mkv have an Internal subtitle stream serenity doesnt show subtitle option for external srt files.
And this is very bad, because a lot of movies downloaded have internal subtitles.

Mkv files without internal subtitle stream and external srt file works perfect with external player.
Internal player with subtitles still not working for me :(

Tv Shows works perfect because never have internal streams for subs, and serenity always detect only SRT file.

@Rocamoya
Copy link
Author

Rocamoya commented Apr 7, 2013

Internal player works with subtitles now, but subtitles are too small and have rare charecters...
Example:

http://s22.postimg.org/6pbi2anhc/AAAAAAAAA.jpg

@kingargyle
Copy link
Contributor

yeah, serenity only works with external subtitles. I may add support at a later date. One option for you is on the Google TV to use ViMu as an external player. It supports subtitles embedded within an MKV I believe. It may be a while before I get to adding similar support to the internal player. Plus I think you can change the size of the font as well.

See the subtitle section within the Help section for ViMu for more detail.

http://player.gtvbox.net/help

@kingargyle
Copy link
Contributor

One more option is to extract the subtitles from the MKV to an SRT.

http://superuser.com/questions/393762/how-to-extract-subtitles-from-mp4-and-mkv-movies

@Rocamoya
Copy link
Author

Rocamoya commented Apr 8, 2013

I cant use Vimu Player because its only for google tv devices, and i dont have avaible download of Vimu player on the Playstore because my device is not google tv, its an Android Tv dongle (Imito MX2).

"One more option is to extract the subtitles from the MKV to an SRT."

I have 2000 Movies on my Collection. U thinks i can extract Subtitle from 1000 or more of my movies? i dont think so. :(

Maybe is more easy u disable detection of the interanal subtitle stream. All my devcis with plex clients have the priority for external SRT file. and never shows internal stream sub.

kingargyle added a commit to kingargyle/serenity-android that referenced this issue Apr 8, 2013
The encoding type of the file was not being considered when reading in
the subtitles, so some characters were not being converted correctly to
UTF-8 format which is Android's default format.

this change checks the encoding and sets up a stream reader so it can
be read properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants