Allow skipping persisting of workflow definitions

nflow-engine/src/main/java/com/nitorcreations/nflow/engine/service/WorkflowDefinitionService.java

@@ -18,6 +18,7 @@
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.core.env.Environment;
 import org.springframework.core.io.AbstractResource;
 import org.springframework.stereotype.Component;
 
@@ -40,13 +41,15 @@ public class WorkflowDefinitionService {
   private final Map<String, WorkflowDefinition<? extends WorkflowState>> workflowDefitions = new LinkedHashMap<>();
   private final WorkflowInstanceDao workflowInstanceDao;
   private final WorkflowDefinitionDao workflowDefinitionDao;
+  private final boolean persistWorkflowDefinitions;
 
   @Inject
   public WorkflowDefinitionService(@NFlow AbstractResource nflowNonSpringWorkflowsListing,
-      WorkflowInstanceDao workflowInstanceDao, WorkflowDefinitionDao workflowDefinitionDao) {
+      WorkflowInstanceDao workflowInstanceDao, WorkflowDefinitionDao workflowDefinitionDao, Environment env) {
     this.nonSpringWorkflowsListing = nflowNonSpringWorkflowsListing;
     this.workflowInstanceDao = workflowInstanceDao;
     this.workflowDefinitionDao = workflowDefinitionDao;
+    this.persistWorkflowDefinitions = env.getRequiredProperty("nflow.definition.persist", Boolean.class);
   }
 
   /**
@@ -90,8 +93,10 @@ public void postProcessWorkflowDefinitions() throws IOException, ReflectiveOpera
     } else {
       initNonSpringWorkflowDefinitions();
     }
-    for (WorkflowDefinition<?> definition : workflowDefitions.values()) {
-      workflowDefinitionDao.storeWorkflowDefinition(definition);
+    if (persistWorkflowDefinitions) {
+      for (WorkflowDefinition<?> definition : workflowDefitions.values()) {
+        workflowDefinitionDao.storeWorkflowDefinition(definition);
+      }
     }
   }
 

nflow-engine/src/main/resources/nflow-engine.properties

@@ -39,3 +39,4 @@ nflow.db.postgresql.url=jdbc:postgresql://localhost/nflow
 nflow.db.max_pool_size=4
 nflow.db.idle_timeout_seconds=600
 nflow.db.create_on_startup=true
+nflow.definition.persist=true

nflow-engine/src/test/java/com/nitorcreations/nflow/engine/service/WorkflowDefinitionServiceTest.java

@@ -17,6 +17,7 @@
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.mockito.Mock;
+import org.springframework.core.env.Environment;
 import org.springframework.core.io.ClassPathResource;
 
 import com.nitorcreations.nflow.engine.internal.dao.WorkflowDefinitionDao;
@@ -35,14 +36,17 @@ public class WorkflowDefinitionServiceTest extends BaseNflowTest {
   private WorkflowInstanceDao workflowInstanceDao;
   @Mock
   private WorkflowDefinitionDao workflowDefinitionDao;
+  @Mock
+  private Environment env;
   private WorkflowDefinitionService service;
 
   @Before
   public void setup() throws Exception {
+    when(env.getRequiredProperty("nflow.definition.persist", Boolean.class)).thenReturn(true);
     String dummyTestClassname = DummyTestWorkflow.class.getName();
     ByteArrayInputStream bis = new ByteArrayInputStream(dummyTestClassname.getBytes(UTF_8));
     when(nonSpringWorkflowListing.getInputStream()).thenReturn(bis);
-    service = new WorkflowDefinitionService(nonSpringWorkflowListing, workflowInstanceDao, workflowDefinitionDao);
+    service = new WorkflowDefinitionService(nonSpringWorkflowListing, workflowInstanceDao, workflowDefinitionDao, env);
     assertThat(service.getWorkflowDefinitions().size(), is(equalTo(0)));
     service.postProcessWorkflowDefinitions();
     assertThat(service.getWorkflowDefinitions().size(), is(equalTo(1)));
@@ -67,7 +71,7 @@ public void demoWorkflowLoadedSuccessfully() {
 
   @Test
   public void nonSpringWorkflowsAreOptional() throws Exception {
-    service = new WorkflowDefinitionService(null, workflowInstanceDao, workflowDefinitionDao);
+    service = new WorkflowDefinitionService(null, workflowInstanceDao, workflowDefinitionDao, env);
     service.postProcessWorkflowDefinitions();
     assertEquals(0, service.getWorkflowDefinitions().size());
   }

nflow-engine/src/test/java/com/nitorcreations/nflow/engine/service/WorkflowDefinitionServiceWithSpringTest.java

@@ -13,7 +13,9 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
+import org.springframework.core.env.Environment;
 import org.springframework.core.io.AbstractResource;
+import org.springframework.mock.env.MockEnvironment;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 import org.springframework.test.context.support.AnnotationConfigContextLoader;
@@ -33,6 +35,10 @@ public class WorkflowDefinitionServiceWithSpringTest {
   @Configuration
   @ComponentScan(basePackageClasses = SpringDummyTestWorkflow.class)
   static class ContextConfiguration {
+    @Bean
+    public Environment env() {
+      return new MockEnvironment().withProperty("nflow.definition.persist", "true");
+    }
 
     @Bean
     @NFlow