Use parameter placeholders when logging.

NitorCreations · Aug 20, 2014 · 7d85811 · 7d85811
1 parent 7c377a1
commit 7d85811
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...ine/src/main/java/com/nitorcreations/nflow/engine/internal/executor/WorkflowExecutor.java b/...ine/src/main/java/com/nitorcreations/nflow/engine/internal/executor/WorkflowExecutor.java
@@ -117,7 +117,7 @@ private WorkflowInstance saveWorkflowInstanceState(StateExecutionImpl execution,
       execution.setNextActivation(null);
     }
     if (definition.getMethod(execution.getNextState()) == null && execution.getNextActivation() != null)  {
-      logger.info("No handler method defined for " + execution.getNextState() + ", clearing next activation");
+      logger.info("No handler method defined for {}, clearing next activation", execution.getNextState());
       execution.setNextActivation(null);
     }
     WorkflowInstance.Builder builder = new WorkflowInstance.Builder(instance)

diff --git a/.../main/java/com/nitorcreations/nflow/engine/internal/storage/db/DatabaseConfiguration.java b/.../main/java/com/nitorcreations/nflow/engine/internal/storage/db/DatabaseConfiguration.java
@@ -23,7 +23,7 @@ protected DatabaseConfiguration(String dbType) {
   @Bean(name="nflow-datasource")
   public DataSource datasource(Environment env) {
     String url = property(env, "url");
-    logger.info("Database connection to " + dbType + " using " + url);
+    logger.info("Database connection to {} using {}", dbType, url);
     HikariConfig config = new HikariConfig();
     config.setDataSourceClassName(property(env, "driver"));
     config.addDataSourceProperty("url", url);

diff --git a/nflow-jetty/src/main/java/com/nitorcreations/nflow/jetty/StartNflow.java b/nflow-jetty/src/main/java/com/nitorcreations/nflow/jetty/StartNflow.java
@@ -91,8 +91,8 @@ public JettyServerContainer startJetty(Map<String, Object> properties) throws Ex
     JettyServerContainer startedServer = new JettyServerContainer(server);
     port = startedServer.getPort();
     logger.info("Successfully started Jetty on port {} in {} seconds in environment {}", port, (end - start) / 1000.0, Arrays.toString(env.getActiveProfiles()));
-    logger.info("API available at http://" + host + ":" + port + "/");
-    logger.info("API doc available at http://" + host + ":" + port + "/ui");
+    logger.info("API available at http://{}:{}/", host, port);
+    logger.info("API doc available at http://{}:{}/ui", host, port);
     return startedServer;
   }