Improve logging WorkflowStateProcessor (#342)

* Improve error logging in WorkflowStateProcessor
NitorCreations · Oct 8, 2019 · e282ba0 · e282ba0
1 parent 6441844
commit e282ba0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -44,6 +44,7 @@
     - Gradle 5.5.1
 - New REST-API endpoint to wake up workflow instance sleeping in specified states
   PUT /nflow/api/v1/workflow-instance/5/wakeup
+- Improve error logging in WorkflowStateProcessor
 
 ## 5.7.0 (2019-06-06)
 

diff --git a/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java b/nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java
@@ -8,6 +8,7 @@
 import static io.nflow.engine.workflow.instance.WorkflowInstance.WorkflowInstanceStatus.inProgress;
 import static io.nflow.engine.workflow.instance.WorkflowInstanceAction.WorkflowActionType.stateExecution;
 import static io.nflow.engine.workflow.instance.WorkflowInstanceAction.WorkflowActionType.stateExecutionFailed;
+import static java.lang.String.format;
 import static java.lang.Thread.currentThread;
 import static java.util.Arrays.asList;
 import static java.util.Collections.emptyList;
@@ -228,11 +229,12 @@ private WorkflowInstance saveWorkflowInstanceState(StateExecutionImpl execution,
       try {
         return persistWorkflowInstanceState(execution, instance.stateVariables, actionBuilder, instanceBuilder);
       } catch (Exception ex) {
-        logger.error("Failed to save workflow instance new state, retrying after {} seconds", stateSaveRetryDelay, ex);
+        logger.error("Failed to save workflow instance {} new state, retrying after {} seconds",
+                instance.id, stateSaveRetryDelay, ex);
         sleepIgnoreInterrupted(stateSaveRetryDelay);
       }
     } while (internalRetryEnabled);
-    throw new IllegalStateException("Failed to save workflow instance new state");
+    throw new IllegalStateException(format("Failed to save workflow instance %s new state", instance.id));
   }
 
   /**