Fix graph translation problem (paths sometimes out of viewbox) #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow graph edges are sometimes hidden outside the viewbox after recent changes. This is fixed by
fit: true
forsvgPanZoom
. The previous causes a new problem:fit
does not understand stroke width leaving nodes touching the viewport edge partially drawn. This is fixed by zooming out 1% after fitting, but after this hack we do get 1) properly visible graph and 2) get rid of many magic numbers.Includes also the following:
svgPanZoom
into factory so that we don't get build time warnings (https://www.jvandemo.com/how-to-properly-integrate-non-angularjs-libraries-in-your-angularjs-application/)