Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph translation problem (paths sometimes out of viewbox) #262

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

eputtone
Copy link
Member

Workflow graph edges are sometimes hidden outside the viewbox after recent changes. This is fixed by fit: true for svgPanZoom. The previous causes a new problem: fit does not understand stroke width leaving nodes touching the viewport edge partially drawn. This is fixed by zooming out 1% after fitting, but after this hack we do get 1) properly visible graph and 2) get rid of many magic numbers.

Includes also the following:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.414% when pulling 816da5e on fix-minor-graph-issues into 6910018 on master.

@efonsell efonsell merged commit b2ad752 into master Oct 18, 2018
@efonsell efonsell deleted the fix-minor-graph-issues branch October 18, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants