Automatic refresh for workflow instance page in Explorer #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmokki
approved these changes
Nov 19, 2018
|
|
||
| function reloadWorkflow(workflowId) { | ||
| console.log('Fetching workflow id ' + workflowId); | ||
| WorkflowService.get(workflowId).then(function(workflow) { |
There was a problem hiding this comment.
If there is already a pending fetch - should we cancel it or skip this fetch? This is for example when the network is down/slow.
There was a problem hiding this comment.
Good point, though the previous pollers (executors, workflow definition) don't do this either. Maybe we should add a task for fixing all the pollers?
| } | ||
| self.poller = $interval(function() { reloadWorkflow(self.workflow.id); }, | ||
| config.radiator.pollPeriod * 1000); | ||
| $scope.$on('$destroy', function() { |
There was a problem hiding this comment.
should we stop the poller if the workflow is in final state?
There was a problem hiding this comment.
No, because someone can move it manually to some non-final state? If someone wants to monitor finished workflow, I think we can grant him 1 rest api call every 15 seconds without overloading the servers :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radiator.pollPeriod