Experimental DB2 support #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efonsell
reviewed
Dec 14, 2018
| Long propsTimeZoneOffsetHours = HOURS.convert( | ||
| TimeZone.getTimeZone(property(env, "timezone")).getOffset(currentTimeMillis()), MILLISECONDS); | ||
| if (!Objects.equals(dbTimeZoneOffsetHours, propsTimeZoneOffsetHours)) { | ||
| throw new RuntimeException("Database has unexpected time zone - hour offset DB2: " + dbTimeZoneOffsetHours + |
There was a problem hiding this comment.
add expected offset to exception message
jsyrjala
reviewed
Dec 14, 2018
|
|
||
| -- Archive tables | ||
| -- - no default values | ||
| -- - no default values |
jsyrjala
reviewed
Dec 14, 2018
| constraint nflow_workflow_uniq unique (type, external_id, executor_group) | ||
| ); | ||
|
|
||
| -- create or replace function update_modified() returns trigger language plpgsql as ' |
There was a problem hiding this comment.
This commented stuff is Oracle related? Could be removed?
There was a problem hiding this comment.
It was just missing :). Integration tests didn't cover checking that modified-column auto-updates. Now they include at least one check.
gmokki
reviewed
Dec 17, 2018
|
|
||
| /** | ||
| * Configuration for DB2 database. Note: tested only using DB2 Express-C (Docker: ibmcom/db2express-c). | ||
| * DB2 database must be configured to UTC time zone, otherwise nFlow will fail to function correctly. |
gmokki
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.