Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pause() and resume() to WorkflowLifecycle #303

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Add pause() and resume() to WorkflowLifecycle #303

merged 4 commits into from
Apr 2, 2019

Conversation

ttiurani
Copy link
Contributor

@ttiurani ttiurani commented Apr 2, 2019

No description provided.

@ttiurani ttiurani requested a review from gmokki April 2, 2019 06:02
efonsell
efonsell reviewed Apr 2, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -6,6 +6,7 @@
- Update libraries for nFlow Explorer. Includes fix for morgan library security issue.
- https://github.com/NitorCreations/nflow/network/alert/nflow-explorer/package-lock.json/morgan/open
- Fix travis build to actually run unit tests for nflow-explorer module.
- Add possibility to pause and resume WorkflowLifecycle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe explain for nFlow users (non-nFlow-developers) what pausing WorkflowLifecycle means in practise?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.414% when pulling 1f2cf7f on pause-and-unpause-to-workflow-lifecycle into cae321c on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.414% when pulling 1f2cf7f on pause-and-unpause-to-workflow-lifecycle into cae321c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.414% when pulling 1f2cf7f on pause-and-unpause-to-workflow-lifecycle into cae321c on master.

@ttiurani ttiurani merged commit 3a3867b into master Apr 2, 2019
@ttiurani ttiurani deleted the pause-and-unpause-to-workflow-lifecycle branch April 2, 2019 11:04
@ttiurani ttiurani mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efonsell efonsell efonsell left review comments

@gmokki gmokki gmokki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ttiurani @coveralls @gmokki @efonsell