Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log executor info on startup. #308

Merged
merged 1 commit into from
May 9, 2019
Merged

Log executor info on startup. #308

merged 1 commit into from
May 9, 2019

Conversation

jsyrjala
Copy link
Member

@jsyrjala jsyrjala commented May 9, 2019 •
edited
Loading

When creating a new executor at startup, log its id, hostname and pid.

09.05.2019 12:47:23 INFO  [main] ngine.internal.dao.ExecutorDao - [user:] Joined executor group junit as executor 2 running on host 123.12.12.123 with process id 90761.

@jsyrjala
Log executor info when creating.
f1b463a 
When creating a new executor at startup, log its id, hostname and pid.
@jsyrjala jsyrjala requested a review from ttiurani May 9, 2019 12:48
@jsyrjala jsyrjala changed the title Log executor info when creating. Log executor info on startup. May 9, 2019
ttiurani
ttiurani approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@ttiurani ttiurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.414% when pulling f1b463a on improve-logging into 5bd2bce on master.

@gmokki gmokki merged commit 7028bfe into master May 9, 2019
@gmokki gmokki deleted the improve-logging branch May 9, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttiurani ttiurani ttiurani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsyrjala @coveralls @ttiurani @gmokki