Replace references to WorkflowDefinition with AbstractWorkflowDefinition #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsyrjala
reviewed
May 15, 2019
nflow-engine/src/main/java/io/nflow/engine/internal/workflow/WorkflowInstancePreProcessor.java
Show resolved
Hide resolved
jsyrjala
reviewed
May 16, 2019
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| ## 5.5.1-SNAPSHOT (future release) | |||
There was a problem hiding this comment.
New feature is added => minor version bump here and in pom.xml files: (5.6.0-SNAPSHOT)
jsyrjala
reviewed
May 16, 2019
|
|
||
| fun repeat(execution: StateExecution): NextAction { | ||
| println("Counter: " + execution.getVariable(VAR_COUNTER)) | ||
| execution.setVariable(VAR_COUNTER, execution.getVar<Int>(VAR_COUNTER) + 1) |
There was a problem hiding this comment.
Where is this getVar<Int> method? Is it some kind of kotlin magic thing?
There was a problem hiding this comment.
Yes, it's Kotlin extension function, and allows nice inline reified typing of the return value (as a type parameter to the function), instead of requiring to pass the type class as a parameter to the function. Kotlin magic...
|
We want to put the two binary |
dahedgehog
force-pushed
the
kotlin-workflow-support
branch
from
ee4c848
to
24e28aa
Compare
efonsell
force-pushed
the
kotlin-workflow-support
branch
from
24e28aa
to
ecd6743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue #311 by replacing references to WorkflowDefinition (which requires use of enum) with AbstractWorkflowDefinition (which works with any WorkflowState type classes).