Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariadb docker #334

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Mariadb docker #334

merged 4 commits into from
Jul 23, 2019

Conversation

gmokki
Copy link
Member

@gmokki gmokki commented Jul 19, 2019

No description provided.

@gmokki gmokki requested a review from efonsell July 19, 2019 12:37
@coveralls
Copy link

coveralls commented Jul 19, 2019

Coverage Status

Coverage remained the same at 72.414% when pulling 321b645 on mariadb-docker into 775424c on master.

@@ -36,6 +38,7 @@
private static final int STEP_1_WORKFLOWS = 4;
private static final int STEP_2_WORKFLOWS = 7;
private static final int STEP_3_WORKFLOWS = 4;
private static final int ARCHIVE_TIMEOUT = 15;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofSeconds(15) here?

@Order(1)
public void cleanupExistingArchivableStuff() {
archiveService.archiveWorkflows(DateTime.now(), 10);
assertTimeoutPreemptively(ofSeconds(ARCHIVE_TIMEOUT), () ->
archiveService.archiveWorkflows(DateTime.now(), 10));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static import

@efonsell efonsell merged commit 775c197 into master Jul 23, 2019
@efonsell efonsell deleted the mariadb-docker branch July 23, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants