Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes for h2 and mssql ddl scripts #347

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

tomkiljo
Copy link
Contributor

Improvements for h2 create ddl, added trigger "if not exists" clause.
Improvements for mssql create ddl, added mssql style "if not exists" clauses.
Fix h2 and mssql latest update ddl (update-5.6.0-X) column started populating.

MSSQL scripts verified with MSSQL 2017-CU14-ubuntu and AzureSQL.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 1d38f71 on ddl-improvements into 8a56891 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 1d38f71 on ddl-improvements into 8a56891 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 1d38f71 on ddl-improvements into 8a56891 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 1d38f71 on ddl-improvements into 8a56891 on master.

@gmokki
Copy link
Member

gmokki commented Nov 10, 2019

Thanks for fixing the upgrade scrips. Looks good.
This shows clearly that we do not currently test the upgrades, although rarely there are any bigger changes like this that need more complex logic.

I'm not sure that if we should have the if not modified -logic, since no one should run the create scripts multiple times. But at least this PR matches what is done in other places so removing them would clearly be a separate PR if we want to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants