Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow and workflow action id from int to long #352

Merged
merged 2 commits into from
Nov 23, 2019
Merged

Conversation

gmokki
Copy link
Member

@gmokki gmokki commented Nov 22, 2019

No description provided.

@gmokki gmokki self-assigned this Nov 22, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 2a7a185 on long_ids into 3e5485c on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 2a7a185 on long_ids into 3e5485c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 2a7a185 on long_ids into 3e5485c on master.

@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage remained the same at 67.742% when pulling 5256f72 on long_ids into 3e5485c on master.

@efonsell
Copy link
Member

Added some minor comments. In general, if we would use long constants instead of magic numbers in tests we would not need to put those Ls everywhere...

@efonsell efonsell merged commit ed692b4 into master Nov 23, 2019
@efonsell efonsell deleted the long_ids branch November 23, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants