Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #357

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Update changelog #357

merged 3 commits into from
Nov 28, 2019

Conversation

gmokki
Copy link
Member

@gmokki gmokki commented Nov 26, 2019

No description provided.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 128e555 on doc-updates into 39013c5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling 128e555 on doc-updates into 39013c5 on master.

@coveralls
Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage remained the same at 67.742% when pulling 4642470 on doc-updates into 39013c5 on master.

Copy link
Contributor

@ttiurani ttiurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me to add info about the reasons. If you want a separate line for Galera workarounds, that's ok, but could also be part of the original line about the prop.

CHANGELOG.md Outdated
@@ -66,6 +67,7 @@
- Improve error logging in WorkflowStateProcessor.
- Replace FindBugs with SpotBugs.
- Drop index from main table that was only used for archiving purposes.
- Increase workflow and action identifiers in code to 64 bits for future proofing. The SQL table definitions stay the same for now, but no code changes are needed if database is altered to use bigint identifiers in large systems. The default 31 bits should be enough for 10 workflows per second with each having 20 steps for 8 years constant load.
Copy link
Contributor

@ttiurani ttiurani Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the caveat is that multi-master databases jump over a lot of integers. In our galera the gap is 3, so 1, 4, 7, 10...

@efonsell
Copy link
Member

When this is merged, please update https://github.com/NitorCreations/nflow/releases/tag/6.0.0 also

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Edvard Fonsell <edvard.fonsell@nitor.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@efonsell efonsell merged commit 0baf0a1 into master Nov 28, 2019
@efonsell efonsell deleted the doc-updates branch November 28, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants