Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps in examples #359

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Update deps in examples #359

merged 4 commits into from
Dec 31, 2019

Conversation

efonsell
Copy link
Member

No description provided.

@efonsell efonsell mentioned this pull request Nov 28, 2019
Closed
@efonsell efonsell removed the request for review from dahedgehog November 28, 2019 13:06
@efonsell
Copy link
Member Author

Need to fix examples so that workflow instance is inserted in startup, otherwise example does not work as described here:
https://github.com/NitorCreations/nflow/wiki/Spring-Boot-guide
The old way of inserting instance in @PostConstruct does not work with 6.0.0, the definitions are not scanned by that time so the insert fails.

@coveralls
Copy link

coveralls commented Nov 28, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 67.742% when pulling 2886c5e on examples into 0baf0a1 on master.

@efonsell
Copy link
Member Author

Inserting instances with ApplicationRunner seems to work

@efonsell efonsell merged commit b5a46a5 into master Dec 31, 2019
@efonsell efonsell deleted the examples branch December 31, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsyrjala jsyrjala jsyrjala approved these changes

@dahedgehog dahedgehog Awaiting requested review from dahedgehog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efonsell @coveralls @jsyrjala