Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check state variable value length when setting variable. #360

Merged
merged 7 commits into from
Dec 13, 2019

Conversation

efonsell
Copy link
Member

Abbreviate or throw exception based on config.

@gmokki
Copy link
Member

gmokki commented Nov 29, 2019

Abbreviate is a good idea. But if it is not enabled, should we schedule the workflow to occur later?
If we just throw exception then it will just usually cause immediate retry of the step

@efonsell
Copy link
Member Author

Abbreviate is a good idea. But if it is not enabled, should we schedule the workflow to occur later?
If we just throw exception then it will just usually cause immediate retry of the step

It will use the normal failure delay of the step, and you can implement custom handling for the exception in the step if you like.

@coveralls
Copy link

coveralls commented Dec 4, 2019

Coverage Status

Coverage remained the same at 67.742% when pulling baf02e3 on state-value-len into 0baf0a1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling baf02e3 on state-value-len into 0baf0a1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling baf02e3 on state-value-len into 0baf0a1 on master.

Copy link
Member

@eputtone eputtone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ookoo

@efonsell efonsell merged commit 7d09f6f into master Dec 13, 2019
@efonsell efonsell deleted the state-value-len branch December 13, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants