Return HTTP 400 Bad Request if trying to insert or update state variables with too long value via REST API #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
gmokki
requested changes
Dec 31, 2019
nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java
Outdated
Show resolved
Hide resolved
...w-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java
Outdated
Show resolved
Hide resolved
...w-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java
Outdated
Show resolved
Hide resolved
nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java
Show resolved
Hide resolved
efonsell
force-pushed
the
state-var-len-rest
branch
from
d3b6fae
to
d4e5e08
Compare
gmokki
reviewed
Jan 3, 2020
nflow-tests/src/test/java/io/nflow/tests/StateVariablesTest.java
Outdated
Show resolved
Hide resolved
gmokki
reviewed
Jan 4, 2020
nflow-jetty/src/main/java/io/nflow/jetty/mapper/WebApplicationExceptionMapper.java
Outdated
Show resolved
Hide resolved
gmokki
approved these changes
Jan 7, 2020
gmokki
reviewed
Jan 7, 2020
|
|
||
| import io.nflow.engine.model.ModelObject; | ||
|
|
||
| public class ErrorResponse extends ModelObject { |
There was a problem hiding this comment.
Should this be shared with the other rest api to keep the api consistent?
No need to use it now, but moving this to the shared project would be wise?
added 14 commits
January 7, 2020 13:26
…bles with too long value via REST API
…ze for state var value column
…ze for state var value column
…ze for state var value column
efonsell
force-pushed
the
state-var-len-rest
branch
from
c7827b3
to
f29a552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.