Honor the includeCurrentStateVariables in the QueryWorkflowInstances #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
efonsell
reviewed
Jan 2, 2020
efonsell
reviewed
Jan 2, 2020
efonsell
reviewed
Jan 3, 2020
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/definition/BulkWorkflow.java
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/definition/BulkWorkflow.java
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/definition/StateExecution.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/definition/StateExecution.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/instance/QueryWorkflowInstances.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/main/java/io/nflow/engine/workflow/instance/QueryWorkflowInstances.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/test/java/io/nflow/engine/internal/dao/WorkflowInstanceDaoTest.java
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/test/java/io/nflow/engine/internal/workflow/StateExecutionImplTest.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jan 3, 2020
nflow-engine/src/test/java/io/nflow/engine/internal/workflow/StateExecutionImplTest.java
Outdated
Show resolved
Hide resolved
gmokki
force-pushed
the
honor-include-statevars
branch
from
88541be
to
adaac44
Compare
efonsell
reviewed
Jan 3, 2020
Co-Authored-By: Edvard Fonsell <edvard.fonsell@nitor.com>
gmokki
force-pushed
the
honor-include-statevars
branch
from
4ce9dd9
to
3e194eb
Compare
efonsell
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed at customer where bulk workflow parent that had ~2k children spent 99% of time by calling
fillStatefor each of the child instances - and the values where never needed for anything.