Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune workflow polling. #371

Merged
merged 12 commits into from
Jan 24, 2020
Merged

Tune workflow polling. #371

merged 12 commits into from
Jan 24, 2020

Conversation

gmokki
Copy link
Member

@gmokki gmokki commented Jan 21, 2020 •
edited
Loading

  • Fetch optimistic locked list of workflow instance ids in separate transaction from the modify phase. This should reduce the risk of deadlocks in databases.
  • Also rework code so that if batch returns unsupported values we switch to non-batch usage.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.714% when pulling 7d1c7d2 on tune-polling into 9d98de7 on master.

@coveralls
Copy link

coveralls commented Jan 21, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 85.836% when pulling 8c4d536 on tune-polling into ee4f264 on master.

@gmokki gmokki force-pushed the tune-polling branch 2 times, most recently from e361ed3 to 618b5b6 Compare January 22, 2020 08:50
@gmokki
Remove polling race condition exception. It is completely normal occu…
eec04c8 
…rence and should not cause any confusing logging. Also rework code so that if batch returns unsupported values we switch to non-batch usage
@gmokki
Fetch optimistic locked list of workflow instance ids in separate tra…
e549c68 
…nsaction from the modify phase. This should reduce the risk of deadlocks in databases.
@gmokki
Add back PollingRaceConditionException to get back the random sleep
53096e2
@gmokki
Tune batch status handling to consider it a failure if more than one …
c8c8ab5 
…row was modified
@gmokki
Restore unit test now that PollingRaceConditionException is back
ea714a1
@gmokki
Return list of ids instead of appending to given empty list
0746f8d
@gmokki
Use streams to process the updates
dbf4c2e
@gmokki
Try 10 times to initiate the race condition
977a698
@gmokki gmokki merged commit e5153e6 into master Jan 24, 2020
@gmokki gmokki deleted the tune-polling branch January 24, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efonsell efonsell efonsell left review comments

@eputtone eputtone Awaiting requested review from eputtone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmokki @coveralls @efonsell