Stream results out of rest api. #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncrhonously, but additional queries are done on the stream lowering latency
3 similar comments
|
Looks good to me. I think this will not actually speed up UI that much, since it will wait until it has received the whole JSON before showing anything. |
jsyrjala
approved these changes
Feb 21, 2020
gmokki
added a commit
that referenced
this pull request
Feb 22, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Feb 22, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Feb 25, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Mar 5, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Apr 18, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Apr 27, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Apr 27, 2020
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
gmokki
added a commit
that referenced
this pull request
Jan 23, 2022
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency * Performance is only lightly improved due to lower memory usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main table query is still done synchronously, but additional queries are done on the stream lowering latency.
Should help with explorer UI, especially if it is later updated to process results lines as they arrive.