Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transition delay data types in WorkflowSettings, remove unused immediateTransitionDelay #385

Merged
merged 9 commits into from
Jan 24, 2022
Merged

Update transition delay data types in WorkflowSettings, remove unused immediateTransitionDelay #385

merged 9 commits into from
Jan 24, 2022

Conversation

efonsell
Copy link
Member

@efonsell efonsell commented Mar 13, 2020 •
edited
Loading

More self-explaining API in WorkflowSettings.Builder: setShortTransitionDelay(millis(50)) vs. setShortTransitionDelay(50)

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 81.72% when pulling 266fead on period into d35a712 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 84.811% when pulling f492103 on period into e1a045b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 84.811% when pulling f492103 on period into e1a045b on master.

@efonsell efonsell requested a review from gmokki April 19, 2020 06:07
@efonsell efonsell changed the title change int millis to Duration period in workflow settings api Change int millis to Duration period in WorkflowSettings API (breaking change -> 8.0.0) Apr 19, 2020
@efonsell efonsell changed the title Change int millis to Duration period in WorkflowSettings API (breaking change -> 8.0.0) Update transition delay data types in WorkflowSettings, remove unused immediateTransitionDelay Jan 23, 2022
gmokki
gmokki reviewed Jan 23, 2022
View reviewed changes
nflow-engine/src/main/java/io/nflow/engine/workflow/definition/WorkflowSettings.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@efonsell efonsell merged commit 277af6f into master Jan 24, 2022
@efonsell efonsell deleted the period branch January 24, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmokki gmokki gmokki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efonsell @coveralls @gmokki