Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for moving to a failure state without retries based on thrown exception and state #386

Merged
merged 17 commits into from
Mar 18, 2020
Merged

Support for moving to a failure state without retries based on thrown exception and state #386

merged 17 commits into from
Mar 18, 2020

Conversation

efonsell
Copy link
Member

@efonsell efonsell commented Mar 17, 2020 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Mar 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 85.043% when pulling b57e9de on non-retryable-errors into e1a045b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 84.94% when pulling 3f5fed5 on non-retryable-errors into e1a045b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 84.94% when pulling 3f5fed5 on non-retryable-errors into e1a045b on master.

add WorkflowState.isRetryable with default implementation that return…
dbd4b30 
…s true, use in AbstractWorkflowDefinition.isRetryable
@efonsell efonsell requested a review from gmokki March 17, 2020 19:24
@efonsell efonsell changed the title Support for moving to a failure state without retries based on thrown exception Support for moving to a failure state without retries based on thrown exception and state.isRetryable Mar 17, 2020
@efonsell efonsell changed the title Support for moving to a failure state without retries based on thrown exception and state.isRetryable Support for moving to a failure state without retries based on thrown exception and state Mar 18, 2020
gmokki
gmokki approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@gmokki gmokki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful feature

@efonsell efonsell merged commit b32deaa into master Mar 18, 2020
@efonsell efonsell deleted the non-retryable-errors branch March 18, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmokki gmokki gmokki approved these changes

@jsyrjala jsyrjala Awaiting requested review from jsyrjala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efonsell @coveralls @gmokki