Better error respones from WorkflowInstanceResource endpoints #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
efonsell
force-pushed
the
invalid-state-update
branch
2 times, most recently
from
c49eae4
to
f5c62c4
Compare
efonsell
changed the title
added 15 commits
April 19, 2020 12:31
…t response in resources
…quest response in resources instead
efonsell
force-pushed
the
invalid-state-update
branch
from
6ff81b0
to
2da8fc3
Compare
gmokki
requested changes
Apr 19, 2020
There was a problem hiding this comment.
This is an api change. We return text/plain from rest apis if an error occurs instead of the previous application/json.
Well actually we do not even test the response content type in the failure tests. But I believe we should keep it at application/json as it was before.
nflow-jetty/src/test/java/io/nflow/jetty/mapper/CustomValidationExceptionMapperTest.java
Outdated
Show resolved
Hide resolved
nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java
Show resolved
Hide resolved
nflow-tests/src/test/java/io/nflow/tests/StateVariablesTest.java
Outdated
Show resolved
Hide resolved
...w-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java
Outdated
Show resolved
Hide resolved
| import io.nflow.rest.v1.msg.ErrorResponse; | ||
|
|
||
| @Provider | ||
| public class StateVariableValueTooLongExceptionMapper implements ExceptionMapper<StateVariableValueTooLongException> { |
There was a problem hiding this comment.
I think there is a tradeoff between putting the error catching&converting logic to one place vs replicating it in every method of the api.
I think we could have one generic exception mapper that just catches Throwable and returns ErrorResponse object.
gmokki
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change nflow-engine to throw IllegalArgumentExceptions instead of IllegalStateExceptions/RuntimeExceptions
Construct error responses with proper HTTP code (400 instead of 500) and message text in WorkflowInstanceResources
Remove ExceptionMapper from nflow-jetty for these cases