Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guice support #392

Merged
merged 13 commits into from
Apr 23, 2020
Merged

Guice support #392

merged 13 commits into from
Apr 23, 2020

Conversation

efonsell
Copy link
Member

@efonsell efonsell commented Apr 16, 2020 •
edited
Loading

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.07%) to 82.897% when pulling f9664df on guice-nflow-710 into 91700e1 on master.

@coveralls
Copy link

coveralls commented Apr 16, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-2.2%) to 82.606% when pulling 35dfddd on guice-nflow-710 into daca838 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.07%) to 82.897% when pulling f9664df on guice-nflow-710 into 91700e1 on master.

@efonsell efonsell requested a review from gmokki April 20, 2020 14:21
gmokki
gmokki previously requested changes Apr 20, 2020
View reviewed changes
nflow-engine/pom.xml Outdated Show resolved Hide resolved
nflow-engine/src/main/java/io/nflow/engine/internal/guice/EngineModule.java Outdated Show resolved Hide resolved
@efonsell efonsell changed the title Update Guice support for nFlow 7.1.0 Guice support Apr 20, 2020
@efonsell efonsell requested a review from gmokki April 23, 2020 05:40
@efonsell efonsell dismissed gmokki’s stale review April 23, 2020 08:08

github glitch, changes were approved

@efonsell efonsell merged commit 049a1f7 into master Apr 23, 2020
@efonsell efonsell deleted the guice-nflow-710 branch April 23, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmokki gmokki gmokki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efonsell @coveralls @gmokki