Inform workflow dispatcher about pending shutdown to allw faster clean shutdown #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w faster clean shutdown
gmokki
changed the title
…ed internalRetryEnabled variable. Tests seem to pass nicely without it
efonsell
reviewed
Apr 17, 2020
nflow-engine/src/main/java/io/nflow/engine/internal/executor/WorkflowStateProcessor.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Apr 17, 2020
...ngine/src/test/java/io/nflow/engine/internal/executor/WorkflowStateProcessorFactoryTest.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Apr 17, 2020
nflow-engine/src/test/java/io/nflow/engine/internal/executor/WorkflowStateProcessorTest.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Apr 17, 2020
nflow-engine/src/test/java/io/nflow/engine/internal/executor/WorkflowStateProcessorTest.java
Outdated
Show resolved
Hide resolved
…n the shutdown was already in progress, tune logging
efonsell
pushed a commit
that referenced
this pull request
Apr 19, 2020
…n shutdown (#393) * Pass information to workflow disptcher about pending shutdown to allow faster clean shutdown * Add test for expedited shutdown for workflow processor. Remove unneeded internalRetryEnabled variable. Tests seem to pass nicely without it * Tune retry loops log properly on shutdown and avoid extra sleeps * Shut down the executor forcibly to interrupt any stuck workflows * Make dispatcher shutdown block until ongoing shutdown is finished when the shutdown was already in progress, tune logging Co-authored-by: Edvard Fonsell <edvard.fonsell@nitorcreations.com>
efonsell
pushed a commit
that referenced
this pull request
Apr 19, 2020
…n shutdown (#393) * Pass information to workflow disptcher about pending shutdown to allow faster clean shutdown * Add test for expedited shutdown for workflow processor. Remove unneeded internalRetryEnabled variable. Tests seem to pass nicely without it * Tune retry loops log properly on shutdown and avoid extra sleeps * Shut down the executor forcibly to interrupt any stuck workflows * Make dispatcher shutdown block until ongoing shutdown is finished when the shutdown was already in progress, tune logging Co-authored-by: Edvard Fonsell <edvard.fonsell@nitorcreations.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.