Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated thread pool for blocking database access #414

Merged
merged 10 commits into from
Dec 22, 2020

Conversation

ttiurani
Copy link
Contributor

@ttiurani ttiurani commented Dec 21, 2020

Currently when using nflow-netty, the netty EventLoop thread blocks during synchronous JDBC database access. Fix this by introducing a separate thread pool for REST API calls.

@coveralls
Copy link

coveralls commented Dec 21, 2020

Coverage Status

Coverage decreased (-0.4%) to 81.301% when pulling 9bb4450 on fix-blocking-webflux into dee0592 on master.

Copy link
Member

@efonsell efonsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some code style things and maybe some test?

Copy link
Member

@efonsell efonsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ttiurani ttiurani merged commit d01defa into master Dec 22, 2020
@ttiurani ttiurani deleted the fix-blocking-webflux branch December 22, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants