Search workflow instances by state variable key and value #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2021 10:14
gmokki
reviewed
Jan 22, 2021
nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java
Outdated
Show resolved
Hide resolved
nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java
Outdated
Show resolved
Hide resolved
|
And I think we do need one test in the testa package that uses the rest api to actually fetch a workflow. Maybe add something to statevar test or some other? |
Yes, I will add a test for this |
added 2 commits
January 22, 2021 22:44
gmokki
approved these changes
Jan 24, 2021
added 2 commits
January 24, 2021 12:55
…comparing in instance query" This reverts commit 9cc5e17.
gmokki
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.