Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow definition refactoring #432

Merged
merged 35 commits into from
Jan 21, 2022
Merged

Workflow definition refactoring #432

merged 35 commits into from
Jan 21, 2022

Conversation

efonsell
Copy link
Member

@efonsell efonsell commented Feb 11, 2021 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Feb 12, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 81.196% when pulling 47874cc on state-refactor into 0d6b6f6 on master.

eputtone
eputtone approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@eputtone eputtone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Looking more like 2020's now.

gmokki
gmokki reviewed Jan 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
gmokki
gmokki reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@gmokki gmokki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to nflow-examples? Do they require changes?

@efonsell
Copy link
Member Author

bare-minimum and full-stack examples updated, full-stack-kotlin todo

@efonsell efonsell merged commit 891c719 into master Jan 21, 2022
@efonsell efonsell deleted the state-refactor branch January 21, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmokki gmokki gmokki approved these changes

@eputtone eputtone eputtone approved these changes

@jsyrjala jsyrjala Awaiting requested review from jsyrjala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@efonsell @coveralls @gmokki @eputtone