-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wait state to cron workflow #434
Conversation
nflow-engine/src/main/java/io/nflow/engine/workflow/curated/CronWorkflow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Pretty nice that completion of child workflow automatically wakes up the parent. I didn't know that. In the example there's no guard against child being still running. I've sometimes missed easy oneliner for checking that.
Easy oneliner added to |
Looks even better to my eye, still approved. StateExecution.hasUnfinishedChildren() is exactly what I've missed occasionally. Though would StateExecution.hasUnfinishedChildWorkflows() be more consistent with the naming of other methods in StateExecution (?) |
…s and fix a bug in the query
Renamed the method and moved the implementation to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 👍
No description provided.