Fix commit unless managed #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In model TestCaseTag, user is an IntegerField not a foreign key referencing to User. Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
commit_unless_managed is deprecated and unavailable in django 1.8. This patch replaces commit_unless_managed with transaction.atomic in testcases and testruns app. Related to #148 Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
|
The tests look good, although we're not really testing the atomic nature of these transactions. However this is fine IMO because I'm planning to refactor these SQL statements in the near future and will update the tests if necessary. I may even drop |
atodorov
approved these changes
Mar 1, 2017
|
It is not necessary to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.