PostProcess: Use lua5_4 for lua #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,7 +129,7 @@ hooks = | |||
| , ("hoogle", set testTarget "--test-option=--no-net") | |||
| , ("hsignal < 0.2.7.4", set phaseOverrides "prePatch = \"rm -v Setup.lhs\";") -- https://github.com/amcphail/hsignal/issues/1 | |||
| , ("hslua < 0.9.3", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_1"))) | |||
| , ("hslua >= 0.9.3 && < 2.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("hslua >= 0.9.3 && < 2.2.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
There was a problem hiding this comment.
Looking at the cabal file for hslua-2.0.0 and hslua-2.1.0, it looks like there are no system packages needed. Is this change here correct?
For example: https://hackage.haskell.org/package/hslua-2.0.0/hslua.cabal
| @@ -129,7 +129,7 @@ hooks = | |||
| , ("hoogle", set testTarget "--test-option=--no-net") | |||
| , ("hsignal < 0.2.7.4", set phaseOverrides "prePatch = \"rm -v Setup.lhs\";") -- https://github.com/amcphail/hsignal/issues/1 | |||
| , ("hslua < 0.9.3", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_1"))) | |||
| , ("hslua >= 0.9.3 && < 2.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("hslua >= 0.9.3 && < 2.2.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
There was a problem hiding this comment.
Looking at the cabal file for hslua-2.0.0 and hslua-2.1.0, it looks like there are no system packages needed. Is this change here correct?
For example: https://hackage.haskell.org/package/hslua-2.0.0/hslua.cabal
| @@ -142,7 +142,8 @@ hooks = | |||
| , ("libxml", set (configureFlags . contains "--extra-include-dir=${libxml2.dev}/include/libxml2") True) | |||
| , ("liquid-fixpoint", set (testDepends . system . contains (pkg "z3")) True . set (testDepends . system . contains (pkg "nettools")) True . set (testDepends . system . contains (pkg "git")) True . set doCheck False) | |||
| , ("liquidhaskell", set (testDepends . system . contains (pkg "z3")) True) | |||
| , ("lua >= 2.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("lua >= 2.0.0 && < 2.2.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("lua >= 2.2.0 && < 3.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_4"))) | |||
There was a problem hiding this comment.
Why the upper bound on 3.0.0 here?
| @@ -142,7 +142,8 @@ hooks = | |||
| , ("libxml", set (configureFlags . contains "--extra-include-dir=${libxml2.dev}/include/libxml2") True) | |||
| , ("liquid-fixpoint", set (testDepends . system . contains (pkg "z3")) True . set (testDepends . system . contains (pkg "nettools")) True . set (testDepends . system . contains (pkg "git")) True . set doCheck False) | |||
| , ("liquidhaskell", set (testDepends . system . contains (pkg "z3")) True) | |||
| , ("lua >= 2.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("lua >= 2.0.0 && < 2.2.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_3"))) | |||
| , ("lua >= 2.2.0 && < 3.0.0", over (libraryDepends . system) (replace (pkg "lua") (pkg "lua5_4"))) | |||
There was a problem hiding this comment.
Why the upper bound on 3.0.0 here?
The latest version of haskellPackages.lua uses lua5_4.
|
LGTM, thanks! For anyone interested, here is the changelog for the haskell package lua about 2.2.0 bumping up to lua-5.4: https://hackage.haskell.org/package/lua-2.2.0/changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of haskellPackages.lua uses lua5_4.
hslua does not directly depend on pkgs.lua any longer, so it is safe
to remove the hook for the newest hslua at the time of
writing (version 2.2.0).