Skip to content

Commit

Permalink
Disable the build-queued hook
Browse files Browse the repository at this point in the history
This can take an excessive amount of time. For example, on
hydra.nixos.org, a call to hydra-notify takes 0.7s even if there are
no plugins. So for an eval with ~45K new builds, the calls to
hydra-notify add up to about 9 hours.

The proper fix would be to pass a list of build IDs, or an eval ID.
  • Loading branch information
edolstra committed Jun 22, 2017
1 parent 207d2dd commit 803833a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/script/hydra-eval-jobset
Expand Up @@ -737,9 +737,9 @@ sub checkJobsetWrapped {
Net::Statsd::increment("hydra.evaluator.evals");
Net::Statsd::increment("hydra.evaluator.cached_evals") unless $jobsetChanged;

while (my ($id, $x) = each %buildMap) {
system("hydra-notify build-queued $id") if $x->{new};
}
#while (my ($id, $x) = each %buildMap) {
# system("hydra-notify build-queued $id") if $x->{new};
#}

# Store the error messages for jobs that failed to evaluate.
my $msg = "";
Expand Down

1 comment on commit 803833a

@domenkozar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @shlevy

Please sign in to comment.