Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-git handles its arguments poorly #329

Open
expipiplus1 opened this issue Jun 13, 2016 · 0 comments
Open

nix-prefetch-git handles its arguments poorly #329

expipiplus1 opened this issue Jun 13, 2016 · 0 comments

Comments

@expipiplus1
Copy link
Contributor

nix-prefetch-git --leave-dotgit will actually pass --leave-dotgit to git remote add as url is unconditionally set to $1 in the third line of the script.
expipiplus1 added a commit to expipiplus1/hydra that referenced this issue Jun 13, 2016
@expipiplus1
Don't set url rev and expHash unconditionally
eda3bae 
These are set properly by the argument parser.

Fixes NixOS#329
@expipiplus1 expipiplus1 mentioned this issue Jun 13, 2016
Closed
@expipiplus1 expipiplus1 changed the title nix-prefetch-git handles it's arguments poorly nix-prefetch-git handles its arguments poorly Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@expipiplus1