Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds abort with RemoteStore::addToStore() not implemented #398

Closed
pikajude opened this issue Oct 12, 2016 · 12 comments
Closed

Builds abort with RemoteStore::addToStore() not implemented #398

pikajude opened this issue Oct 12, 2016 · 12 comments

Comments

@pikajude
Copy link

See https://hydra.jude.bio/build/1700#tabs-buildsteps

Using hydra @ 7221bd7 and nix @ edf9eb8181e01f6b2123e5690019cfeeb44fc1c2

@domenkozar
Copy link
Member

cc @edolstra

@edolstra
Copy link
Member

@pikajude You could apply NixOS/nix#1053, it implements RemoteStore::addToStore.

@pikajude
Copy link
Author

pikajude commented Oct 12, 2016

@edolstra that now causes all builds to fail with messages like this:

Oct 12 11:59:12 web hydra-queue-runner[5651]: possibly transient failure building ‘/nix/store/cz5wqqfv20w2r6i2pgvbd6xyypzs68j0-autogen-5.18.7.drv’ on ‘localhost’: cannot import path ‘/nix/store/10rs5p8rfa45p9ljjm9mpxf3n43hi7bn-autogen-5.18.7-man’ because it lacks a valid signature

@copumpkin
Copy link
Member

@pikajude that's probably worth posting to NixOS/nix#1053, since otherwise @shlevy won't see it (except that I just highlighted him now)

@shlevy
Copy link
Member

shlevy commented Oct 13, 2016

@pikajude Do you have nix updated on both ends?

@pikajude
Copy link
Author

@shlevy hydra only uses localhost for builds, and the nix.package I'm using is the same one that hydra is using.

@shlevy
Copy link
Member

shlevy commented Oct 13, 2016

Oh, wait. This is expected. You need to either sign your paths or be a trusted daemon user to addToStore.

@shlevy
Copy link
Member

shlevy commented Oct 13, 2016

I'm confused as to why this is even happening at all. @edolstra did you change hydra recently to require my PR?

@pikajude
Copy link
Author

@shlevy Agreed. In nix master, addToStore has been unimplemented since May 4, and Hydra worked without interference between then and now.

@edolstra
Copy link
Member

It's using addToStore implicitly since ee2e9f5.

@shlevy
Copy link
Member

shlevy commented Oct 13, 2016

@edolstra So is the solution here to always turn on build signing?

@pikajude
Copy link
Author

@shlevy if that's the case, how do I turn on build signing?

edolstra added a commit that referenced this issue Nov 9, 2016
Fixes #398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants