Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two "The following builds match your query" lists ? #695

Open
simonmichael opened this issue Dec 6, 2019 · 1 comment
Open

Two "The following builds match your query" lists ? #695

simonmichael opened this issue Dec 6, 2019 · 1 comment

Comments

@simonmichael
Copy link

After a hledger release, I search for nix builds at https://hydra.nixos.org/search?query=hledger. This eventually produces a long list of jobs (which I ignore) and then two lists of builds, each with a "The following builds match your query:" heading. They look similar but not quite the same. I wonder why there are two lists ?

@simonmichael simonmichael changed the title Multiple "The following builds match your query" sections ? Two "The following builds match your query" lists ? Dec 6, 2019
@basvandijk
Copy link
Member

Hi Simon, a quick read of the source reveals the following explanation:

The build search results are rendered here. Note that there are two calls of the renderBuildSearch template defined above corresponding to the two lists of builds you see.

Note that renderBuildSearch defaults to rendering the data in builds. However the second call overrides builds with buildsdrv.

The results are computed here. As you can see builds contains builds with an output path that matches your query while buildsdrv contains builds with a derivation path that matches your query.

It would be better if the template would describe this difference by returning something like:

The output paths of the following builds match your query

and:

The derivation paths of the following builds match your query

Care to submit a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants