Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "timed out" and "log limit exceeded" builds aborted #1369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make "timed out" and "log limit exceeded" builds aborted #1369

wants to merge 1 commit into from

Commits on Mar 13, 2024

  1. Make "timed out" and "log limit exceeded" builds aborted 

    In 7369408 I gave builds that failed
because of a timeout or exceeded log limit a stop sign and I stand by
that reasoning: with that it's possible to distinguish between actual
build failures and rather transient things such as timeouts.

Back then I considered it a feature that these are shown in a different
tab, but I don't think that's a good idea anymore. When using a jobset to
e.g. track the regressions from a mass rebuild (like a compiler or gcc
update), "Newly failed builds" should exclusively display regressions (and
flaky builds of course, not much I can do about that).

Also, when a bunch of builds fail in such a jobset because of e.g. a
broken connection to a builder that results in a timeout, I want to be
able to restart them all w/o rebuilding actual regressions.

To make it clear that we not only have "Aborted" builds in the tab, I
renamed the label to "Aborted / Timed out".
    @Ma27
    Ma27 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f9a6f31 View commit details
    Browse the repository at this point in the history