Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobset -> JobsetEvals by JobsetEvals.jobset_id #850

Merged
merged 10 commits into from Jan 28, 2021

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 26, 2021

Instead of referring to the jobset by its project's name and the jobset's name, refer to it by a jobset_id.

  • I added a little in-line notes about how to write database migrations.
  • I fixed a problem where the make for updating the schema libraries would succeed even if the SQL was invalid.
  • I fixed a minor problem where hydra-dev-server was buffering output to stderr/stdout
  • The C++ in hydra-evaluator feels a bit heavy on boilerplate, but it seemed like a good way to go. I'm open to doing something different. I wrote this in a few separate commits to make it easier for me to grok.
  • The perl patches were surprisingly short and easy. I clicked around, ran the tests, ran some evaluations and builds

src/hydra-evaluator/hydra-evaluator.cc Outdated Show resolved Hide resolved
src/hydra-evaluator/hydra-evaluator.cc Outdated Show resolved Hide resolved
src/hydra-evaluator/hydra-evaluator.cc Outdated Show resolved Hide resolved
src/hydra-evaluator/hydra-evaluator.cc Outdated Show resolved Hide resolved
@grahamc
Copy link
Member Author

grahamc commented Jan 28, 2021

Thanks for the review, @edolstra! I'll merge once it goes green.

@grahamc grahamc merged commit 6d047c2 into NixOS:master Jan 28, 2021
@grahamc grahamc deleted the jobset-evals-by-id branch January 28, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants