Make eval restriction an option instead of forcing #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might make sense to leave a note in e.g. |
|
I wanted to document it next to the other evaluator options but they are not documented either 😆 |
|
It seems like this would result in un-reproducible builds and builds that can be dependent on elements not captured in the store or the derivation? |
|
Yes |
|
Maybe you could say more about what problem this addresses, because a CI testing system that doesn't generate builds that are reproducible or stable doesn't seem ... useful? |
|
AFAIR this enables IFD. Edit: NixOS/nix#1888 (comment) |
|
I am not thrilled that such an inauspicious PR got such an auspicious number. |
|
Any updates on this? I don't really see why this would not be an option. cc @grahamc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.