Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.outputsToInstall: store and propogate #911

Closed
wants to merge 4 commits into from

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 12, 2021

Allow RunCommand to access the outputs to install, and propagate the fake expressions to the generated Nix channel.

* hydra-eval-jobs: emit outputsToInstall from the meta
* hydra-eval-jobset: collect and save the outputsToInstall
* schema: updated to store the field
Now nix-env will respect the outputsToInstall when using the
bogus channel.
@edolstra
Copy link
Member

I'm not very enthusiastic about adding a column to the Builds table to support an essentially deprecated feature (Hydra channels, or channels in general). It would probably be better to move channel generation out of Hydra (e.g. into a RunCommand script, or the way the NixOS/Nixpkgs channels are updated).

@grahamc
Copy link
Member Author

grahamc commented Apr 15, 2021

This was originally developed for the generated Nix channel, but the user of that feature has stopped using it. Now, it is being used to provide the outputsToInstall data to the RunCommand hook.

@grahamc
Copy link
Member Author

grahamc commented Jul 7, 2021

note to self: replace this PR with storing more of the derivation data as a json blob field, and maybe another field with the meta data.

@grahamc grahamc closed this Feb 1, 2022
@grahamc grahamc deleted the outputs-to-install-re branch March 10, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants