Skip to content

Commit

Permalink
kernel-builder: Call either of install or zinstall
Browse files Browse the repository at this point in the history
It seems that under specific conditions:

 - 2a5 hardware
 - -j22

the call to `make install zinstall` (simplified here) may break, with
the installation of `System.map` happening in a manner where it fails
the build. It was not trivial to reproduce elsewhere than on a 2a5
machine, for unknown reasons.

It was also only observed on google-walleye, but there is no reason is
shouldn't be failing on other devices too.

Odd.
  • Loading branch information
samueldr committed Dec 31, 2020
1 parent 5386b3f commit 29a1008
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions overlay/mobile-nixos/kernel/builder.nix
Expand Up @@ -337,10 +337,8 @@ stdenv.mkDerivation (inputArgs // {
# no-op buildPhase if we combine build and install steps
buildPhase = if enableCombiningBuildAndInstallQuirk then ":" else null;

installTargets = [
"install"
]
++ optional (isCompressed != false) "zinstall"
installTargets =
if isCompressed != false then [ "zinstall" ] else [ "install" ]
++ installTargets
;

Expand Down

0 comments on commit 29a1008

Please sign in to comment.