kernel-builder: Avoid string interpolation for path concatenation #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using string interpolation for concatenating paths caused the whole
nixpkgs source to be included as an "inputSrc" for the kernel derivation.
linux.drv:
"inputSrcs": [
...
"/nix/store/4crmmrpb9axxymrrh77lf35n015scnpj-mobile-nixos",
...
],
With concatenation, only the resulting file is included as an
"inputSrc", which avoids unnecessary kernel rebuilds when nixpkgs
changes.
linux.drv:
"inputSrcs": [
...
"/nix/store/hdr6v584ig3dpjlcs9afxxky3lvzm2nw-randstruct-provide-seed.patch",
...
],
|
Hi! Thanks for the fix. It's so easy to overlook such things, if you see anything else of the sort, don't hesitate to share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using string interpolation for concatenating paths caused the whole nixpkgs source to be included as an
inputSrcfor the kernel derivation.linux.drv:
I have my mobile-nixos worktree of nixpkgs under
nixpkgs/mobile-nixos, which is why the above is namedmobile-nixos.With concatenation, only the resulting file is included as an
inputSrc, which avoids unnecessary kernel rebuilds when nixpkgs changes.linux.drv: